Conversation
greenc-FNAL
requested review from
Copilot,
knoepfel,
marcpaterno and
sabasehrish
|
@phlexbot cmake-fix |
|
Automatic cmake-format fixes pushed (commit c2b60b7). |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #410 +/- ##
==========================================
- Coverage 84.43% 84.40% -0.04%
==========================================
Files 127 127
Lines 3329 3329
Branches 564 564
==========================================
- Hits 2811 2810 -1
Misses 325 325
- Partials 193 194 +1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds an opt-in CMake configuration to profile build-time behavior (compile and link), helping developers identify expensive translation units and link steps during Phlex builds.
Changes:
- Introduces
ENABLE_BUILD_PROFILINGCMake option to wrap compile/link rules withcmake -E time. - Enables compile time tracing (
-ftime-trace) for Clang/GNU toolchains when profiling is enabled. - Enables additional LLD link tracing/statistics flags when LLD is detected.
greenc-FNAL
force-pushed
the
maintenance/enable-build-profiling
branch
from
c2b60b7 to
b0e703f
Compare
|
Review the full CodeQL report for details. |
greenc-FNAL
force-pushed
the
maintenance/enable-build-profiling
branch
from
b0e703f to
ec28a53
Compare
|
@greenc-FNAL, is this comment by Copilot relevant? If not, please resolve the conversation. |
It looks relevant at first blush, although the linker's map file writer might be parallel-safe. I'll try to look later; sorry for false start. |
Remove --Map=phlex_link.map from the global LLD link options: since multiple targets are linked in parallel, using a hardcoded filename would cause all link jobs to race to write the same file, resulting in corrupt or overwritten output. The --time-trace option already generates a per-target trace file (appending .time-trace to the output file name), and --print-archive-stats=- writes to stdout, so neither of those has this issue. Also correct an if(...) formatting issue caught by gersemi. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
greenc-FNAL
force-pushed
the
maintenance/enable-build-profiling
branch
from
ec28a53 to
a38525d
Compare
No description provided.